Skip to content

feat: Add read-only getters for Point.fields and Point.tags #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bednar merged 4 commits into from
Dec 18, 2025
Merged

feat: Add read-only getters for Point.fields and Point.tags #828

bednar merged 4 commits into from
Dec 18, 2025

Conversation

@g3n35i5
Copy link
Contributor

@g3n35i5 g3n35i5 commented Jul 13, 2025 •
edited
Loading

This makes testing easier.

Proposed Changes

I am currently contributing to a Jenkins Plugin which uses InfluxDB. Testing this plugin currently requires the use of Java reflections in order to compare written tags and fields.

Adding read-only getter functions for tags and fields would make this more easy.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

g3n35i5 added a commit to g3n35i5/influxdb-client-java that referenced this pull request Jul 13, 2025
@g3n35i5
docs: Add influxdata#828 to changelog
8be4f1f
@g3n35i5 g3n35i5 force-pushed the feat/public-getters branch from d9f5ac6 to 48b0080 Compare July 13, 2025 18:41
@g3n35i5 g3n35i5 marked this pull request as ready for review July 13, 2025 19:07
@g3n35i5
Copy link
Contributor Author

g3n35i5 commented Jul 13, 2025 •
edited
Loading

@bednar I don't know what happened in the failed check ...

@bednar
Copy link
Contributor

bednar commented Jul 21, 2025

@g3n35i5, the client-backpressure check is flaky, so feel free to ignore it.

@g3n35i5
Copy link
Contributor Author

g3n35i5 commented Dec 17, 2025

@bednar any updated on this?

@bednar bednar force-pushed the feat/public-getters branch from 48b0080 to e01137c Compare December 18, 2025 08:58
@bednar bednar self-requested a review December 18, 2025 08:59
bednar
bednar approved these changes Dec 18, 2025
View reviewed changes
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.81%. Comparing base (256cbdb) to head (996b13c).
⚠️ Report is 6 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #828      +/-   ##
============================================
+ Coverage     88.79%   88.81%   +0.01%     
- Complexity      778      791      +13     
============================================
  Files           174      174              
  Lines          7248     7250       +2     
  Branches        413      413              
============================================
+ Hits           6436     6439       +3     
+ Misses          681      680       -1     
  Partials        131      131

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bednar bednar merged commit e2fbb3a into influxdata:master Dec 18, 2025
10 checks passed
@bednar
Copy link
Contributor

bednar commented Dec 18, 2025

@g3n35i5 is is merged into master branch. How urgent is the release?

@g3n35i5
Copy link
Contributor Author

g3n35i5 commented Dec 18, 2025

Thanks! I just contributed this for better testability in other libraries, since there are workarounds it is not time critical.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bednar bednar bednar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@g3n35i5 @bednar @codecov-commenter